Skip to content

ci: exclude META-INF/services file for VaadinServiceInitListener#87

Merged
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1
Dec 19, 2025
Merged

ci: exclude META-INF/services file for VaadinServiceInitListener#87
paodb merged 1 commit intomasterfrom
javier-godoy-patch-1

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Dec 19, 2025 •
edited by coderabbitai bot
Loading

Close #86

Summary by CodeRabbit

  • Chores
    • Updated build configuration to optimize artifact packaging.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 19, 2025 •
edited
Loading

Walkthrough

Modified pom.xml to exclude the META-INF/services/com.vaadin.flow.server.VaadinServiceInitListener service descriptor file from the demo test-jar artifact. This prevents a ServiceConfigurationError when the chipfield addon is included in the demo site.

Changes

Cohort / File(s) Summary
Maven profile configuration
pom.xml		 Added exclusion path to demo-jar profile to exclude META-INF/services/com.vaadin.flow.server.VaadinServiceInitListener from demo test-jar artifact

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: excluding a META-INF/services file for VaadinServiceInitListener in the CI build configuration.
Linked Issues check ✅ Passed The PR excludes the VaadinServiceInitListener services file from the demo JAR, which directly addresses the ServiceConfigurationError reported in issue #86.
Out of Scope Changes check ✅ Passed The pom.xml change is focused solely on excluding the problematic services file and is directly scoped to resolving the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch javier-godoy-patch-1
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 345967d and 6e6f416.

📒 Files selected for processing (1)
  • pom.xml (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: javier-godoy
Repo: FlowingCode/ChipFieldAddon PR: 85
File: pom.xml:133-138
Timestamp: 2025-12-18T16:26:46.955Z
Learning: In the ChipFieldAddon project (FlowingCode/ChipFieldAddon), the ASM dependency version is intentionally set to 9.8 to maintain compatibility with Vaadin 23-24, which depends on that version. The project supports multiple Vaadin versions through Maven profiles (v23, v24, v25).
📚 Learning: 2025-12-18T16:26:33.407Z 
Learnt from: javier-godoy
Repo: FlowingCode/ChipFieldAddon PR: 85
File: pom.xml:133-138
Timestamp: 2025-12-18T16:26:33.407Z
Learning: In Maven projects like ChipFieldAddon, pin the ASM dependency to version 9.8 to maintain compatibility with Vaadin 23–25. Use the existing profiles (v23, v24, v25) to select the appropriate Vaadin setup and ensure the ASM version remains aligned with Vaadin compatibility. Add comments in pom.xml where this rationale is documented, and when upgrading Vaadin versions, re-validate that ASM 9.8 remains compatible or adjust both the ASM version and the profile configuration accordingly.

Applied to files:

  • pom.xml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-vaadin14
  • GitHub Check: build-vaadin24
  • GitHub Check: build-vaadin25
  • GitHub Check: build-vaadin23
🔇 Additional comments (1)
pom.xml (1)

370-370: Service descriptor exclusion correctly addresses the root cause.

Excluding the META-INF/services/com.vaadin.flow.server.VaadinServiceInitListener file from the demo JAR is the right fix. The service loader would otherwise attempt to instantiate ViewInitializerImpl (a test-only class), causing the ServiceConfigurationError. This exclusion prevents the descriptor from being bundled while allowing test-scoped classes to remain excluded via the existing **/integration/* pattern.

The fix looks correct, but please verify that this single exclusion fully resolves issue #86 when the demo site is run against Vaadin 25. You may want to test the integration mentioned in the PR description to confirm there are no remaining service-related errors.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@paodb paodb merged commit b77e9e4 into master Dec 19, 2025
7 checks passed
@paodb paodb deleted the javier-godoy-patch-1 branch December 19, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paodb paodb paodb approved these changes

@mlopezFC mlopezFC Awaiting requested review from mlopezFC

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vaadin 25 demo: Provider ViewInitializerImpl not found

2 participants

@javier-godoy @paodb